chore: remove unneeded conditions #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
next
branch
3 times, most recently
from
5a759ab to
8967b30
Compare
G-Rath
force-pushed
the
next
branch
3 times, most recently
from
d28ffb3 to
b22de65
Compare
G-Rath
force-pushed
the
next
branch
2 times, most recently
from
8d2bc7c to
6255746
Compare
SimenB
force-pushed
the
next
branch
5 times, most recently
from
4833db1 to
c15972d
Compare
SimenB
force-pushed
the
next
branch
2 times, most recently
from
a542c31 to
2549e6a
Compare
|
@SimenB as much as I'd like to get the major out, Do we want to wait for that, or just cut another major in a few months? I'm fine with either. |
|
The only reason v2 is breaking for us is because it drops old versions of node, right? Are there any breaking changes planned for v4 of the utils? |
|
Yeah, not that I know of. The release is just for the new AST shape for optional chaining & co, which we don't use so we should be fine to bump in a minor. |
|
Let's aim for that 🙂 Would be awesome to get a new major out in teh next couple of days |
G-Rath
changed the title
@typescript-eslint dependencies
SimenB
pushed a commit
that referenced
this pull request
Aug 22, 2020
These are not needed with `@typescript-eslint@3`
SimenB
pushed a commit
that referenced
this pull request
Aug 22, 2020
These are not needed with `@typescript-eslint@3`
SimenB
pushed a commit
that referenced
this pull request
Aug 24, 2020
These are not needed with `@typescript-eslint@3`
SimenB
pushed a commit
that referenced
this pull request
Aug 24, 2020
These are not needed with `@typescript-eslint@3`
SimenB
pushed a commit
that referenced
this pull request
Aug 31, 2020
These are not needed with `@typescript-eslint@3`
SimenB
pushed a commit
that referenced
this pull request
Sep 4, 2020
These are not needed with `@typescript-eslint@3`
SimenB
pushed a commit
that referenced
this pull request
Sep 4, 2020
These are not needed with `@typescript-eslint@3`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #590