Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-large-snapshots): run on files of any type #581

Closed
wants to merge 1 commit into from
Closed

fix(no-large-snapshots): run on files of any type #581

wants to merge 1 commit into from

Conversation

graphan
Copy link

@graphan graphan commented May 14, 2020 •
edited by G-Rath
Loading

Adjusts no-large-snapshots so that it checks files of any type.

closes #370

@codecov
Copy link

codecov bot commented May 14, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@0d9dce0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master      #581   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        45           
  Lines             ?      1398           
  Branches          ?       578           
==========================================
  Hits              ?      1398           
  Misses            ?         0           
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d9dce0...99b1ae5. Read the comment docs.

@graphan graphan mentioned this pull request May 14, 2020
Closed
@G-Rath
Copy link
Collaborator

G-Rath commented May 14, 2020 •
edited
Loading

@graphan this failing danger because you've not provided a description for your PR.

@SimenB I think the codecoverage comment has stopped Danger from posting it's comment for some reason?

Also, I'm thinking we push this into next since it's technically breaking and we've got a new major just around the corner.

@G-Rath G-Rath changed the title fix(no-large-snapshots): toMatchInlineSnapshot working with TypeScript fix(no-large-snapshots): run on files of any type May 14, 2020
@G-Rath
Copy link
Collaborator

G-Rath commented May 14, 2020

Oh actually danger is failing because of an actual error:

Request failed [403]: https://api.github.com/repos/jest-community/eslint-plugin-jest/issues/581/comments
Response: {
  "message": "Resource not accessible by integration",
  "documentation_url": "https://developer.github.com/v3/issues/comments/#create-a-comment"
}
Feedback: undefined

@G-Rath G-Rath mentioned this pull request May 14, 2020
Closed
SimenB
SimenB reviewed May 14, 2020
View reviewed changes
src/rules/__tests__/no-large-snapshots.test.ts
@@ -41,11 +41,6 @@ ruleTester.run('no-large-snapshots', rule, {
'toThrowErrorMatchingInlineSnapshot',
),
},
{
// "it should return an empty object for non snapshot files"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nove it to invalid to validate it fails for non .js?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry @SimenB, I don't get your question. Could you rephrase it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB bumping up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no test that asserts test files with any extension is tested - instead of removing the test that asserts unknown extensions are not tested, change it to verify it is tested

G-Rath added a commit that referenced this pull request Aug 2, 2020
@G-Rath
fix(no-large-snapshots): run on all files regardless of type
5302363 
BREAKING CHANGE

closes #370
closes #581
G-Rath added a commit that referenced this pull request Aug 2, 2020
@G-Rath
fix(no-large-snapshots): run on all files regardless of type
bba35d0 
BREAKING CHANGE

closes #370
closes #581
@G-Rath G-Rath mentioned this pull request Aug 2, 2020
Merged
@SimenB
Copy link
Member

SimenB commented Aug 8, 2020

#637

@SimenB SimenB closed this Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-large-snapshots should not care about file types
3 participants
@graphan @G-Rath @SimenB