Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(padding-around-test-blocks): update description #1691

Merged

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Dec 30, 2024

I have fixed the padding-around-test-blocks rule documentation.

Copy link
Collaborator

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - would you mind updating this to include it as well?

@@ -27,6 +27,6 @@ export const config = [

export default createPaddingRule(
__filename,
'Enforce padding around afterAll blocks',
'Enforce padding around `test` blocks',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Enforce padding around `test` blocks',
'Enforce padding around `test` and `it` blocks',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed in 5f7c7b0.

@G-Rath G-Rath force-pushed the docs/fix-padding-around-test-blocks branch from 5f7c7b0 to 523a127 Compare January 13, 2025 19:13
@G-Rath G-Rath force-pushed the docs/fix-padding-around-test-blocks branch from 523a127 to b563390 Compare January 15, 2025 00:47
@G-Rath G-Rath changed the title docs: corrected the title of the padding-around-test-blocks rule documentation fix(padding-around-test-blocks): update description Jan 15, 2025
@G-Rath G-Rath merged commit 9cb4ecc into jest-community:main Jan 15, 2025
53 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
## [28.10.1](v28.10.0...v28.10.1) (2025-01-15)

### Bug Fixes

* **padding-around-test-blocks:** update description ([#1691](#1691)) ([9cb4ecc](9cb4ecc))
Copy link

🎉 This PR is included in version 28.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@y-hsgw y-hsgw deleted the docs/fix-padding-around-test-blocks branch January 15, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants