ci: run against upcoming next major ESLint version

.eslintrc.js

@@ -98,7 +98,7 @@ module.exports = {
       globals,
     },
     {
-      files: ['src/**/*', 'dangerfile.ts', 'tools/*'],
+      files: ['src/**/*', 'dangerfile.ts', 'tools/*', './jest.config.ts'],
       parserOptions: {
         sourceType: 'module',
       },

.github/workflows/nodejs.yml

@@ -72,12 +72,15 @@ jobs:
       fail-fast: false
       matrix:
         node-version: [16.x, 18.x, 19.x, 20.x, 21.x]
-        eslint-version: [7, 8]
+        eslint-version: [7, 8, next]
         ts-eslint-plugin-version: [6, 7]
         exclude:
           # ts-eslint/plugin@7 doesn't support node@16
           - node-version: 16.x
             ts-eslint-plugin-version: 7
+          # eslint@9 doesn't support node@16
+          - node-version: 16.x
+            eslint-version: next
           # ts-eslint/plugin@7 doesn't support node@19
           - node-version: 19.x
             ts-eslint-plugin-version: 7
@@ -103,7 +106,7 @@ jobs:
           yarn add --dev eslint@${{ matrix.eslint-version }} @typescript-eslint/eslint-plugin@${{ matrix.ts-eslint-plugin-version }} @typescript-eslint/parser@${{ matrix.ts-eslint-plugin-version }}
       - name: run tests
         # only collect coverage on eslint versions that support dynamic import
-        run: yarn test --coverage ${{ matrix.eslint-version >= 8 }}
+        run: yarn test --coverage ${{ matrix.eslint-version == 8 }}
         env:
           CI: true
       - uses: codecov/codecov-action@v3

jest.config.ts

@@ -0,0 +1,58 @@
+import { version as typescriptESLintPluginVersion } from '@typescript-eslint/eslint-plugin/package.json';
+import { version as eslintVersion } from 'eslint/package.json';
+import type { Config } from 'jest';
+import * as semver from 'semver';
+
+const config = {
+  clearMocks: true,
+  restoreMocks: true,
+  resetMocks: true,
+
+  coverageThreshold: {
+    global: {
+      branches: 100,
+      functions: 100,
+      lines: 100,
+      statements: 100,
+    },
+  },
+
+  projects: [
+    {
+      displayName: 'test',
+      testPathIgnorePatterns: [
+        '<rootDir>/lib/.*',
+        '<rootDir>/src/rules/__tests__/fixtures/*',
+        '<rootDir>/src/rules/__tests__/test-utils.ts',
+      ],
+      coveragePathIgnorePatterns: ['/node_modules/'],
+    },
+    {
+      displayName: 'lint',
+      runner: 'jest-runner-eslint',
+      testMatch: ['<rootDir>/**/*.{js,ts}'],
+      testPathIgnorePatterns: ['<rootDir>/lib/.*'],
+      coveragePathIgnorePatterns: ['/node_modules/'],
+    },
+  ],
+} satisfies Config;
+
+if (semver.major(eslintVersion) >= 9) {
+  config.projects = config.projects.filter(
+    ({ displayName }) => displayName !== 'lint',
+  );
+
+  // jest/unbound-method doesn't work when using @typescript-eslint v6
+  if (semver.major(typescriptESLintPluginVersion) === 6) {
+    for (const project of config.projects) {
+      project.testPathIgnorePatterns.push(
+        '<rootDir>/src/rules/__tests__/unbound-method.test.ts',
+      );
+      project.coveragePathIgnorePatterns.push(
+        '<rootDir>/src/rules/unbound-method.ts',
+      );
+    }
+  }
+}
+
+export default config;

package.json

@@ -64,36 +64,6 @@
       "@semantic-release/github"
     ]
   },
-  "jest": {
-    "coverageThreshold": {
-      "global": {
-        "branches": 100,
-        "functions": 100,
-        "lines": 100,
-        "statements": 100
-      }
-    },
-    "projects": [
-      {
-        "displayName": "test",
-        "testPathIgnorePatterns": [
-          "<rootDir>/lib/.*",
-          "<rootDir>/src/rules/__tests__/fixtures/*",
-          "<rootDir>/src/rules/__tests__/test-utils.ts"
-        ]
-      },
-      {
-        "displayName": "lint",
-        "runner": "jest-runner-eslint",
-        "testMatch": [
-          "<rootDir>/**/*.{js,ts}"
-        ],
-        "testPathIgnorePatterns": [
-          "<rootDir>/lib/.*"
-        ]
-      }
-    ]
-  },
   "dependencies": {
     "@typescript-eslint/utils": "^6.0.0"
   },

src/rules/__tests__/consistent-test-it.test.ts

@@ -1,10 +1,9 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../consistent-test-it';
 import { TestCaseName } from '../utils';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2015,

src/rules/__tests__/expect-expect.test.ts

@@ -1,9 +1,9 @@
-import { AST_NODE_TYPES, TSESLint } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../expect-expect';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2015,

src/rules/__tests__/max-expects.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../max-expects';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2017,

src/rules/__tests__/max-nested-describe.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../max-nested-describe';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2017,

src/rules/__tests__/no-alias-methods.test.ts

@@ -1,7 +1,7 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import rule from '../no-alias-methods';
+import { FlatCompatRuleTester } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester();
+const ruleTester = new FlatCompatRuleTester();
 
 ruleTester.run('no-alias-methods', rule, {
   valid: [

src/rules/__tests__/no-commented-out-tests.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../no-commented-out-tests';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2015,

src/rules/__tests__/no-conditional-expect.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../no-conditional-expect';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2019,

src/rules/__tests__/no-conditional-in-test.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../no-conditional-in-test';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2015,

src/rules/__tests__/no-confusing-set-timeout.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../no-confusing-set-timeout';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2020,

src/rules/__tests__/no-deprecated-functions.test.ts

@@ -4,14 +4,15 @@ import {
   type JestVersion,
   detectJestVersion,
 } from '../utils/detectJestVersion';
+import { FlatCompatRuleTester, usingFlatConfig } from './test-utils';
 
 jest.mock('../utils/detectJestVersion');
 
 const detectJestVersionMock = detectJestVersion as jest.MockedFunction<
   typeof detectJestVersion
 >;
 
-const ruleTester = new TSESLint.RuleTester();
+const ruleTester = new FlatCompatRuleTester();
 
 const generateValidCases = (
   jestVersion: JestVersion | string | undefined,
@@ -154,6 +155,20 @@ describe('the rule', () => {
       expect(() => {
         const linter = new TSESLint.Linter();
 
+        /* istanbul ignore if */
+        if (usingFlatConfig) {
+          linter.verify('jest.resetModuleRegistry()', [
+            {
+              plugins: {
+                jest: { rules: { 'no-deprecated-functions': rule } },
+              },
+              rules: { 'jest/no-deprecated-functions': 'error' },
+            },
+          ]);
+
+          return;
+        }
+
         linter.defineRule('no-deprecated-functions', rule);
 
         linter.verify('jest.resetModuleRegistry()', {

src/rules/__tests__/no-disabled-tests.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../no-disabled-tests';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2015,

src/rules/__tests__/no-done-callback.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../no-done-callback';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2017,

src/rules/__tests__/no-duplicate-hooks.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../no-duplicate-hooks';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2015,

src/rules/__tests__/no-export.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../no-export';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2015,

src/rules/__tests__/no-focused-tests.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../no-focused-tests';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 6,

src/rules/__tests__/no-hooks.test.ts

@@ -1,10 +1,9 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../no-hooks';
 import { HookName } from '../utils';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2015,

src/rules/__tests__/no-identical-title.test.ts

@@ -1,9 +1,8 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import dedent from 'dedent';
 import rule from '../no-identical-title';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2015,

src/rules/__tests__/no-interpolation-in-snapshots.test.ts

@@ -1,8 +1,7 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import rule from '../no-interpolation-in-snapshots';
-import { espreeParser } from './test-utils';
+import { FlatCompatRuleTester, espreeParser } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester({
+const ruleTester = new FlatCompatRuleTester({
   parser: espreeParser,
   parserOptions: {
     ecmaVersion: 2017,

src/rules/__tests__/no-jasmine-globals.test.ts

@@ -1,7 +1,7 @@
-import { TSESLint } from '@typescript-eslint/utils';
 import rule from '../no-jasmine-globals';
+import { FlatCompatRuleTester } from './test-utils';
 
-const ruleTester = new TSESLint.RuleTester();
+const ruleTester = new FlatCompatRuleTester();
 
 ruleTester.run('no-jasmine-globals', rule, {
   valid: [