Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(valid-title): support ignoring leading and trailing whitespace #1433

Merged
merged 2 commits into from
Sep 15, 2023
Merged

feat(valid-title): support ignoring leading and trailing whitespace #1433

merged 2 commits into from
Sep 15, 2023

Conversation

sanyatuning
Copy link
Contributor

@sanyatuning sanyatuning commented Sep 15, 2023 •
edited
Loading

We use BDD style test names and want some trailing space for formatting

describe('Feature: ...', () => {
    it(`GIVEN ...
        WHEN ...
        THEN ...
    `, () => {
        // test body
    });
});

@sanyatuning sanyatuning force-pushed the valid-title-ignore-spaces branch from cd2017b to d395e72 Compare September 15, 2023 10:13
@G-Rath G-Rath changed the title add ignoreSpaces option to valid-title rule feat(valid-title): support ignoring leading and trailing whitespace Sep 15, 2023
@G-Rath G-Rath merged commit bc96473 into jest-community:main Sep 15, 2023
github-actions bot pushed a commit that referenced this pull request Sep 15, 2023
@semantic-release-bot
chore(release): 27.4.0 [skip ci]
42fec48 
# [27.4.0](v27.3.0...v27.4.0) (2023-09-15)

### Features

* **valid-title:** support ignoring leading and trailing whitespace ([#1433](#1433)) ([bc96473](bc96473))
@github-actions
Copy link

🎉 This PR is included in version 27.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Rath G-Rath G-Rath approved these changes

Assignees
No one assigned
Labels
released rule: valid-title
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanyatuning @G-Rath