-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add smoke test workflow #1000
Conversation
0a1e832
to
7601a38
Compare
with: | ||
node-version: 16 | ||
- run: | | ||
npm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Npm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can't get yarn link
working - happy if you want to have a crack at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yarn had some issues to get package linking working across host and docker container. Same issues were seen with older npm versions: jsx-eslint/eslint-plugin-react#3120 (comment).
- uses: AriPerkkio/eslint-remote-tester-run-action@v2 | ||
with: | ||
issue-title: 'Results of weekly scheduled smoke test' | ||
eslint-remote-tester-config: smoke-test/eslint-remote-tester.config.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is missing?
🎉 This PR is included in version 25.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Came across this when picking up work for
eslint-plugin-jest-dom
- seems like a pretty cool thing to have for us too.