Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule request: title-matches-pattern #233

Closed
dashmug opened this issue Mar 5, 2019 · 2 comments · Fixed by #608
Closed

New rule request: title-matches-pattern #233

dashmug opened this issue Mar 5, 2019 · 2 comments · Fixed by #608
Labels
released

Comments

@dashmug
Copy link

dashmug commented Mar 5, 2019

Some teams might want to have a convention for their test titles. A lint rule that can enforce this will be very useful.

Options can be added to further specify whether the rule applies to describe, it, or test.
@G-Rath
Copy link
Collaborator

G-Rath commented Jun 20, 2020

Now that we have valid-title, I think it makes sense to support this as an option for that rule, rather than as a new rule; something like mustMatch, which takes a RegExp-as-a-string or an object of type Record<'describe' | 'it' | 'test', string>.

@G-Rath G-Rath mentioned this issue Jun 20, 2020
Closed
G-Rath added a commit that referenced this issue Jun 21, 2020
@G-Rath
feat(valid-title): support mustMatch option
66fd721 
Closes #233
G-Rath added a commit that referenced this issue Jun 21, 2020
@G-Rath
feat(valid-title): support mustMatch option
a70a4cc 
Closes #233
@G-Rath G-Rath mentioned this issue Jun 21, 2020
Merged
G-Rath added a commit that referenced this issue Jun 21, 2020
@G-Rath
feat(valid-title): support mustMatch option
2e755dd 
Closes #233
G-Rath added a commit that referenced this issue Jun 22, 2020
@G-Rath
feat(valid-title): support mustMatch & mustNotMatch options
d845372 
Closes #233
G-Rath added a commit that referenced this issue Jun 22, 2020
@G-Rath
feat(valid-title): support mustMatch & mustNotMatch options
6c34c88 
Closes #233
G-Rath added a commit that referenced this issue Jul 5, 2020
@G-Rath
feat(valid-title): support mustMatch & mustNotMatch options (#608)
4c7207e 
Closes #233
github-actions bot pushed a commit that referenced this issue Jul 5, 2020
@semantic-release-bot
chore(release): 23.18.0 [skip ci]
73efaea 
# [23.18.0](v23.17.1...v23.18.0) (2020-07-05)

### Features

* **valid-title:** support `mustMatch` & `mustNotMatch` options ([#608](#608)) ([4c7207e](4c7207e)), closes [#233](#233)
@github-actions
Copy link

github-actions bot commented Jul 5, 2020

🎉 This issue has been resolved in version 23.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(valid-title): support mustMatch & mustNotMatch options jest-community/eslint-plugin-jest
2 participants
@dashmug @G-Rath