Fix issue #275 #276
Merged
Fix issue #275 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change restores the old behaviour of PassAfterNonOption working together with commands so that a command would (also) get everything after the first non-option, while also preserving the new behaviour of those non-options landing in the positional array if provided. The behaviour for when a command and a positional array are both present continues to be weird (but it's unclear whether there's a non-weird way out of that one other than failing with a "don't do that").
|
To be clear, the weird behaviour with commands + positional happens if they're at the same level—I added a test to check for a command that had a positional array, as that one works fine and is clear. |
jessevdk
requested changes
Sep 27, 2018
|
sure!
…On Thu, Sep 27, 2018 at 8:42 AM Jesse van den Kieboom < ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Cool! Could you move the additional tests to command_test.go?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#276 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABeNBsQZbB06gEVs-CjNOcqSna0a_tYEks5ufIF7gaJpZM4W61wJ>
.
--
John Lenton ([email protected]) ::: http://chipaca.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores the old behaviour of PassAfterNonOption working
together with commands so that a command would (also) get everything
after the first non-option, while also preserving the new behaviour of
those non-options landing in the positional array if provided.
The behaviour for when a command and a positional array are both
present continues to be weird (but it's unclear whether there's a
non-weird way out of that one other than failing with a "don't do
that").