Fix PassAfterNonOption not working with positional args #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
PassAfterNonOption
work correctly (the same asPassDoubleDash
), when used with positional args (as opposed to "unspecified" args being returned byParse
).I'm not sure this is clear enough, so let me give examples:
-v -- -g
-v
, returns["-g"]
-v
and setsRest
to["-g"]
, returns[]
-v arg -g
-v
, returns["args", "-g"]
-g
and fails ❗I argue that this bottom-right case is wrong, it should instead not try to parse
-g
but setRest
to["arg", "-g"]
. This PR fixes this.