This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Bug Fix #1449 #1476
Closed
Bug Fix #1449 #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't seem like you can change the height of the inputToolbar using the documented property preferredDefaultHeight since it is used to configure the height constraint in viewDidLoad. In order to fix the bug I added the line of code: self.toolbarHeightConstraint.constant = self.inputToolbar.preferredDefaultHeight; In the method: viewWillAppear, and now the view load with the correct constraints.
|
Hey @GuyKahlon — this looked good, what's the reason for closing? |
|
I don't know, I got a message some unit tests are failed, I send you a new pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
What's in this pull request?
It doesn't seem like you can change the height of the inputToolbar using the documented property preferredDefaultHeight since it is used to configure the height constraint in viewDidLoad.
In order to fix the bug I added the line of code:
self.toolbarHeightConstraint.constant = self.inputToolbar.preferredDefaultHeight;
In the method:
viewWillAppear, and now the view load with the correct constraints.