Bug Fix #1449 #1472
Bug Fix #1449 #1472
Conversation
…Toolbar preferredDefaultHeight. It doesn't seem like you can change the height of the inputToolbar using the documented property preferredDefaultHeight since it is used to configure the height constraint in viewDidLoad. In order to fix the bug I added the line of code: self.toolbarHeightConstraint.constant = self.inputToolbar.preferredDefaultHeight; In the method: viewWillAppear, and now the view load with the correct constraints.
| @@ -196,7 +196,8 @@ - (void)viewWillAppear:(BOOL)animated | |||
| [super viewWillAppear:animated]; | |||
| [self.view layoutIfNeeded]; | |||
| [self.collectionView.collectionViewLayout invalidateLayout]; | |||
|
|
|||
| self.toolbarHeightConstraint.constant = self.inputToolbar.preferredDefaultHeight; | |||
There was a problem hiding this comment.
we should probably put this before layoutIfNeeded above, right?
|
Thanks @GuyKahlon ! Looks good. 😄 If you can, could we remove commit 701fd26 from this? (seems like an accident) |
This reverts commit 701fd26.
|
Hey @jessesquires, Commit 701fd26 has been removed. |
|
👍 last thing, mind squashing these commits into 1? 😄 |
…Toolbar preferredDefaultHeight.
|
Hey Jesse, I tried to squash the committees into 1 with rebase (http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html) but it looks worse now, we have a 5 comments after the merge. Do you prefer I'll send you a new Pull Request with just 1 commit? Sorry about all the mess 😁 |
|
@GuyKahlon -- sometimes a new pull request is easiest 😁 |
|
subsumed by #1477 |
Hey Jesse,
Pull request checklist
What's in this pull request?
Fix very small bug from the open issues.
Thanks,
Guy