Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

Renamed custom action method #1010

Closed
wants to merge 3 commits into from

Conversation

sebastianludwig
Copy link
Collaborator

This prevents the custom action being present in the input text view menu. Another case of "Singletons shouldn't be the first choice" - this application wide shared menu controller is just horrible :-(

@nikkoss the issue you mentioned in #811 arose because the customAction: selector is registered at the UIMenuController and DemoMessageViewController did implement it. When the context menu of the text input is shown, the menu controller checks if the underlying object(s? - I guess the views, but for sure the view controller) responds to the selector. In case of customAction: it did, so the action was added.

I see two ways around this: 1. proxy to a different selector (see this PR) with the downside of Undeclared selector warnings. 2. Let another object than the view controller be the collection view delegate. This would require some major code restructuring.

@jessesquires jessesquires added this to the Release 7.1.2 milestone Jun 3, 2015
@jessesquires
Copy link
Owner

thanks @sebastianludwig !

@jessesquires
Copy link
Owner

Hey @sebastianludwig - After thinking some more, I think (2) is actually the better solution, which will eventually be resolved by #453. Having the undeclared selector warnings in the demo doesn't feel right.

Going to close this.

@jessesquires jessesquires removed this from the 7.1.2 milestone Aug 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants