This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Renamed custom action method #1010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt in the input text view menu.
|
thanks @sebastianludwig ! |
…roller into develop
…roller into develop
|
Hey @sebastianludwig - After thinking some more, I think (2) is actually the better solution, which will eventually be resolved by #453. Having the undeclared selector warnings in the demo doesn't feel right. Going to close this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the custom action being present in the input text view menu. Another case of "Singletons shouldn't be the first choice" - this application wide shared menu controller is just horrible :-(
@nikkoss the issue you mentioned in #811 arose because the
customAction:selector is registered at theUIMenuControllerandDemoMessageViewControllerdid implement it. When the context menu of the text input is shown, the menu controller checks if the underlying object(s? - I guess the views, but for sure the view controller) responds to the selector. In case ofcustomAction:it did, so the action was added.I see two ways around this: 1. proxy to a different selector (see this PR) with the downside of
Undeclared selectorwarnings. 2. Let another object than the view controller be the collection view delegate. This would require some major code restructuring.