initial github actions implementation #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessek
approved these changes
Dec 2, 2024
|
Hi @jessek — I appreciate you approving it, but it doesn't work yet! Let me get it working first. |
|
Ah. I see why it doesn't work. It has all of the "please generate a fatal error on any warning" throughout. How do you want to handle this? Should we actually fix all the code? Or simple disable the warnings? |
|
I think it's ok to turn off "treat warnings as errors". This code is so old we'd spend a lot of time trying to update it just to avoid compiler warnings. FWIW, I tried to compile it today and got warnings from bootstrap.sh and then configure failed. Let's get it working again and then we can clean it up. |
|
That seems like a good plan. We’ve been going through something similar on
the sleuth kit side.
…On Mon, Dec 2, 2024 at 3:34 PM Jesse Kornblum ***@***.***> wrote:
I think it's ok to turn off "treat warnings as errors". This code is so
old we'd spend a lot of time trying to update it just to avoid compiler
warnings.
FWIW, I tried to compile it today and got warnings from bootstrap.sh and
then configure failed. Let's get it working again and then we can clean it
up.
—
Reply to this email directly, view it on GitHub
<#419 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMFHLGI6YQW6377OOU5RGT2DS75FAVCNFSM6AAAAABS2GYX62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJSG42TQNBTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will have bugs, but it's a start.