Highlight (reverse) hyperlinks on mouse hover #3857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We send this event when the mouse is moved but no button is down. Can be used for highlighting things on mouse hover.
We don't underline them at all any more, so if clients would like to show links underlined by default for better discoverability, they need to add the underline attribute themselves.
Now that gocui no longer does this for us, we need to add the underline attribute on our side.
6 tasks
|
Closing, as everybody (except me) prefers the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #3856: here we change gocui so that it doesn't underline links at all, ever (if clients want that, they need to add the underline attribute themselves). Instead, we highlight links on hover by using the reverse attribute.
I prefer this to #3856: it looks better, at least for the line numbers in delta diffs, and it is much easier to see.