Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce lowercase filenames #2578

Merged
merged 1 commit into from
Apr 29, 2023
Merged

Conversation

jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Apr 29, 2023

  • PR Description

Go does not enforce a convention on case in filenames (see here). But the standard library uses snake case, and so we're enforcing that here too.

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go run scripts/cheatsheet/main.go generate)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2023

Uffizzi Preview deployment-23711 was deleted.

@jesseduffield jesseduffield force-pushed the enforce-lowercase-filenames branch from 82078cb to 117d6b5 Compare April 29, 2023 03:01
@jesseduffield jesseduffield force-pushed the enforce-lowercase-filenames branch from 117d6b5 to aec4694 Compare April 29, 2023 03:05
@jesseduffield jesseduffield changed the title enforce lowercase filenames Enforce lowercase filenames Apr 29, 2023
@jesseduffield
Copy link
Owner Author

@stefanhaller this affects your rebaseTodo.go and rebaseTodo_test.go files. I've confirmed locally that you can rebase without conflicts and it'll apply the change to your branch

@jesseduffield jesseduffield merged commit 826128a into master Apr 29, 2023
@jesseduffield jesseduffield deleted the enforce-lowercase-filenames branch April 29, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant