Skip to content

Commit

Permalink
Improve fixup commits script
Browse files Browse the repository at this point in the history
This script is failing currently on
#3631 because that fork's
master branch is 300 commits behind our own, but the feature branch is
up to date.

The thing is, we don't actually need to involve the master branch. All
we care about is the feature branch's own commits, so this commit simply
fetches those commits and checks them.
  • Loading branch information
jesseduffield committed Aug 23, 2024
1 parent 7679b10 commit addfa2f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 20 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,8 @@ jobs:
if: github.ref != 'refs/heads/master'
steps:
# See https://github.com/actions/checkout/issues/552#issuecomment-1167086216
- name: "PR commits + 1"
run: echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 1 ))" >> "${GITHUB_ENV}"
- name: "PR commits"
run: echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} ))" >> "${GITHUB_ENV}"

- name: "Checkout PR branch and all PR commits"
uses: actions/checkout@v4
Expand All @@ -235,10 +235,6 @@ jobs:
ref: ${{ github.event.pull_request.head.ref }}
fetch-depth: ${{ env.PR_FETCH_DEPTH }}

- name: "Fetch the other branch with enough history for a common merge-base commit"
run: |
git fetch origin ${{ github.event.pull_request.base.ref }}
- name: Check for fixups
run: |
./scripts/check_for_fixups.sh ${{ github.event.pull_request.base.ref }}
17 changes: 3 additions & 14 deletions scripts/check_for_fixups.sh
Original file line number Diff line number Diff line change
@@ -1,19 +1,8 @@
#!/bin/sh

base_ref=$1

# Determine the base commit
base_commit=$(git merge-base HEAD origin/"$base_ref")

# Check if base_commit is set correctly
if [ -z "$base_commit" ]; then
echo "Failed to determine base commit."
exit 1
fi
echo "Base commit: $base_commit"

# Get commits with "fixup!" in the message from base_commit to HEAD
commits=$(git log -i -E --grep '^fixup!' --grep '^squash!' --grep '^amend!' --grep '^[^\n]*WIP' --grep '^[^\n]*DROPME' --format="%h %s" "$base_commit..HEAD")
# We will have only done a shallow clone, so the git log will consist only of
# commits on the current PR
commits=$(git log --grep='^fixup!' --grep='^squash!' --grep='^amend!' --grep='^[^\n]*WIP' --grep='^[^\n]*DROPME' --format="%h %s")

if [ -z "$commits" ]; then
echo "No fixup commits found."
Expand Down

0 comments on commit addfa2f

Please sign in to comment.