Chefspec 3.1 #28
Merged
Chefspec 3.1 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
COOK-4120 in tickets.opscode.com |
Closed
| @@ -12,11 +12,11 @@ | |||
| expect(template).to be | |||
| expect(template.source).to eq('munin-node.conf.erb') | |||
| expect(template.mode).to eq('0644') | |||
| expect(template).to notify('service[munin-node]', :restart) | |||
| notify('service[munin-node]').to(:restart) | |||
There was a problem hiding this comment.
This isn't a test - you want:
expect(template).to notify('service[munin-node]').to(:restart)This whole test should read:
expect(chef_run).to create_template('/etc/munin/munin-node.conf').with(
source: 'munin-node.conf.erb',
mode: '0644',
)
template = chef_run.template('/etc/munin/munin-node.conf')
expect(template).to notify('service[munin-node]').to(:restart)- depend on chefspec ~>3.1 instead of ~>3.1.0 - simplify the preparation of the runner in server_spec.rb - linebreaks for server_spec.rb - improve the template and service tests in client_spec.rb
|
This could be better? |
|
@kampfschlaefer - Thanks for your work on this. Can you please fix the error? |
|
@sethvargo - Thanks for the comments |
|
@jesseadams I would love to fix the error. If I could reproduce it (did a |
|
It looks like this is an issue with rubocop v0.16.0 and rainbow v2.0.0 and is now fixed in rubocop v0.18.0, released today. |
|
Thanks for the heads up @btm. Will try that out here in a bit. |
|
I had Travis re-run the build and it's passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to write some more tests for munin. But munin only makes sense with a lot of searching and real results. So it would be fun to use chef-solo with chefspec for munin. Which in turn requires upcoming chefspec3.1.
So lets make this cookbook depend on chefspec3.1.0.beta.1.
Oh, and set the auth-method to htpasswd so the cookbook converges without throwing an error because of missing openid-stuff.