Add extraContainers parameter to helm chart #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jertel
requested changes
Oct 11, 2022
CHANGELOG.md
Outdated
| @@ -9,6 +9,7 @@ | |||
| ## Other changes | |||
| - Upgrade pylint 2.15.2 to 2.15.3 and pytest-cov 3.0.0 to 4.0.0 and sphinx 5.1.1 to 5.2.3; Add Google Chat proxy support - [#972](https://github.com/jertel/elastalert2/pull/972) - @nsano-rururu | |||
| - Fix Jira assign issue - [#974](https://github.com/jertel/elastalert2/pull/974) - @jorge-gyant | |||
| - Add extraContainers value to helm chart | |||
There was a problem hiding this comment.
Please fix formatting of changelog:
- [Kubernetes] Add extraContainers value to helm chart - [#975](https://github.com/jertel/elastalert2/pull/975) - @Kasape
chart/elastalert2/README.md
Outdated
| @@ -78,6 +78,7 @@ The command removes all the Kubernetes components associated with the chart and | |||
| | `secretRulesName` | name of the secret which holds the ElastAlert rules. **Note:** this will overwrite the generated rules | `NULL` | | |||
| | `secretRulesList` | a list of rules to enable from the secret | [] | | |||
| | `optEnv` | Additional pod environment variable definitions | [] | | |||
| | `extraContainers` | List of additional containers run in the same pod as elasticalert | [] | | |||
There was a problem hiding this comment.
Fix typo. Should be elastalert, not elasticalert
|
Fixed, thanks for your comments |
jertel
approved these changes
Oct 11, 2022
|
Hi @jertel, could you please create a new release to include this change? I would really appreciate having this functionality in a helm chart. Thank you |
Hi Kasape, I should be able to release the next version within the next week or so. |
|
2.8.0 has been released and includes this change. |
|
Thank you, I will use it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parameter
extraContainerswas added to values.yaml in helm chart and it is passed to the definition of deployment. It allows a user to define additional containers running in the same pod next to the elastalert container. An example of an additional running container is a sidecar that shares mounted volume with the elastalert and changes the content of the folder with rules. The same methodology and notation are used in grafana helm-chart.Checklist
make test-dockerwith my changes.Questions or Comments