Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scan subdirectories an option in helm chart #805

Merged
merged 6 commits into from
Apr 6, 2022
Merged

Make scan subdirectories an option in helm chart #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
537927b
add subdirectory scanning as an option in Helm
Apr 5, 2022
16b31e8
missing readme documentation
Apr 5, 2022
e71ee19
changelog for version 2.4.1
Apr 5, 2022
cc62791
update PR according to feeback from Jertel
Apr 6, 2022
44093b1
Merge branch 'master' into master
louzadod Apr 6, 2022
5c2c137
Fix pattern of changelog
jertel Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
- Upgrade pylint 2.13.2 to 2.13.3 - [#792](https://github.com/jertel/elastalert2/pull/792) - @nsano-rururu
- Upgrade pylint 2.13.3 to 2.13.4 - [#801](https://github.com/jertel/elastalert2/pull/801) - @nsano-rururu
- Fix SpikeRule - [#804](https://github.com/jertel/elastalert2/pull/804) - @nsano-rururu
- [Kubernetes] Add scanSubdirectories (defaults to true) as an option in Helm Chart - [#805](https://github.com/jertel/elastalert2/pull/805) - @louzadod

# 2.4.0

Expand Down
1 change: 1 addition & 0 deletions chart/elastalert2/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ The command removes all the Kubernetes components associated with the chart and
| `rules` | Rule and alert configuration for ElastAlert 2 | {} example shown in values.yaml |
| `runIntervalMins` | Default interval between alert checks, in minutes | 1 |
| `realertIntervalMins` | Time between alarms for same rule, in minutes | `NULL` |
| `scanSubdirectories` | Enable/disable subdirectory scanning for rules | `true` |
| `alertRetryLimitMins` | Time to retry failed alert deliveries, in minutes | 2880 (2 days) |
| `bufferTimeMins` | Default rule buffer time, in minutes | 15 |
| `writebackIndex` | Name or prefix of elastalert index(es) | elastalert |
Expand Down
4 changes: 3 additions & 1 deletion chart/elastalert2/templates/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ data:
elastalert_config: |-
---
rules_folder: /opt/elastalert/rules
scan_subdirectories: false
{{- if .Values.scanSubdirectories }}
scan_subdirectories: {{ .Values.scanSubdirectories }}
{{- end }}
run_every:
minutes: {{ .Values.runIntervalMins }}
{{- if .Values.realertIntervalMins }}
Expand Down
3 changes: 3 additions & 0 deletions chart/elastalert2/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ revisionHistoryLimit: 5
# Default internal between alert checks against the elasticsearch datasource, in minutes
runIntervalMins: 1

# Enable/disabe subdirectory scanning for rules
scanSubdirectories: true

# Default rule buffer duration, in minutes
bufferTimeMins: 15

Expand Down