Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS Teams] Add arbitrary text value support for Facts #790

Merged
merged 6 commits into from
Mar 30, 2022

Conversation

iamxeph
Copy link
Contributor

@iamxeph iamxeph commented Mar 30, 2022

Description

Make ms_teams_alert_facts have arbitrary text value for its 'value' by returning 'value' itself

Let's say you have configured the alerter like this:

alert_subject: "Test Alert for ElastAlert2"
alert_text: "body"
alert_text_type: alert_text_only
ms_teams_alert_facts:
  - name: Host
    value: agent.name
  - name: What to do
    value: Page your boss

Currently it outputs to MS Teams like this:

image

This PR change the output to this:

image

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@iamxeph iamxeph marked this pull request as ready for review March 30, 2022 09:52
@jertel jertel merged commit ec11e5b into jertel:master Mar 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants