Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for basic auth to alertmanager #575

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Add support for basic auth to alertmanager #575

merged 3 commits into from
Nov 24, 2021

Conversation

nsano-rururu
Copy link
Collaborator

@nsano-rururu nsano-rururu commented Nov 23, 2021 •
edited
Loading

Description

We are responding to the following discussion requests.
#572

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@nsano-rururu nsano-rururu requested a review from jertel November 23, 2021 14:01
@jertel jertel merged commit 133b76d into jertel:master Nov 24, 2021
@nsano-rururu nsano-rururu deleted the alertmanamger_add_basic_auth branch November 24, 2021 15:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jertel jertel jertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsano-rururu @jertel