Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default max_scrolling_count to 990 to avoid stack overflow #509

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Default max_scrolling_count to 990 to avoid stack overflow #509

merged 2 commits into from
Oct 12, 2021

Conversation

jertel
Copy link
Owner

@jertel jertel commented Oct 12, 2021

Description

Default max_scrolling_count to 990 to avoid stack overflow. Python has a stack frame limit of 1000, and since the run_query() method recursively pages through the scroll it can result in a stack overflow if there are sufficient results to be fetched.

Checklist

  • I have reviewed the contributing guidelines.
  • [N/A] I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

See #493 for more information.

@nsano-rururu nsano-rururu merged commit db73204 into master Oct 12, 2021
@nsano-rururu nsano-rururu deleted the scroll_limit branch October 31, 2021 11:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nsano-rururu nsano-rururu nsano-rururu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jertel @nsano-rururu