Including time_taken in the statsd metrics #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffAshton
commented
Jul 2, 2021
| @@ -986,6 +987,27 @@ def run_rule(self, rule, endtime, starttime=None): | |||
| 'time_taken': time_taken} | |||
| self.writeback('elastalert_status', body) | |||
|
|
|||
| # Write metrics about the run to statsd | |||
| if self.statsd: | |||
There was a problem hiding this comment.
Moved from below to where time_taken was readily available.
This feels aligned with the elastalert_status work that run_rule is already doing above. Would also allow for measuring of elastalert-test-rule.
jertel
approved these changes
Jul 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
time_takento the statsd work @eladamitpxi did.