Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #317 - Add support jinja2 support to alert_subject #318

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

mrfroggg
Copy link
Contributor

Opened to modification:
I re-used alert_text_type = alert_text_jinja to render alert_subject: reason is, I would not want to add another parameter that most users wouldn't know about.
And, I think that if you are using jinja2 templates for your alert_text, there's a lot of chance you would want to have the same configuration with alert_subject.

And it won't break configs, it will still check for alert_subject_args first.

@jertel jertel merged commit 3856219 into jertel:master Jun 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants