Fix #317 - Add support jinja2 support to alert_subject #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened to modification:
I re-used
alert_text_type
=alert_text_jinja
to renderalert_subject
: reason is, I would not want to add another parameter that most users wouldn't know about.And, I think that if you are using jinja2 templates for your alert_text, there's a lot of chance you would want to have the same configuration with alert_subject.
And it won't break configs, it will still check for alert_subject_args first.