[Opsgenie] Added possibility to specify source and entity attrs
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2021 13:01
Priority attr can now be templated from first match
konstantin-kornienko
changed the title
source and entity attrs.source and entity attrs
jertel
reviewed
Jun 30, 2021
JeffAshton
reviewed
Jul 2, 2021
| priority = self.priority | ||
| if priority: | ||
| priority = priority.format(**matches[0]) | ||
| if priority and priority not in ('P1', 'P2', 'P3', 'P4', 'P5'): |
There was a problem hiding this comment.
nit: Could this block be indented as well? The second priority check won't be successful if the first one fails
jertel
added a commit
that referenced
this pull request
Jul 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sourceattribute now can be specified in rule.Previously it was hardcoded to
ElastAlert, now it just the default. So this PR will not break previous behavior.entityattribute now can be specified in rule.priorityattribute can now be templated from the first match.