Coverage improvement by adding test code, etc. #294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary code
dingtalk.py
I left behind unnecessary code. I'm sorry.
opsgeine.py
I found that the code removed in Yelp/elastalert#1876 on the yelp / elastalert pull request was accidentally revived and left in the Yelp/elastalert#1935 pull request, so I removed it.
Improved test coverage
TOTAL
68% → 70%
dingtalk.py
97% → 100%
email.py
89% → 90%
exotel.py
61% → 100%
jira.py
74% → 76%
opsgeine.py
92% → 96%
ses.py
37% → 62%
sns.py
53% → 83%
stomp.py
20% → 81%
twilio.py
83% → 100%
zabbix.py
54% → 57%