Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage improvement by adding test code, etc. #294

Merged
merged 6 commits into from
Jun 25, 2021

Conversation

nsano-rururu
Copy link
Collaborator

Remove unnecessary code

dingtalk.py

I left behind unnecessary code. I'm sorry.

    def format_body(self, body):
        return body.encode('utf8')

opsgeine.py

I found that the code removed in Yelp/elastalert#1876 on the yelp / elastalert pull request was accidentally revived and left in the Yelp/elastalert#1935 pull request, so I removed it.

    def _fill_responders(self, responders, type_):
        return [{'id': r, 'type': type_} for r in responders]

Improved test coverage

TOTAL
68% → 70%

dingtalk.py
97% → 100%
email.py
89% → 90%
exotel.py
61% → 100%
jira.py
74% → 76%
opsgeine.py
92% → 96%
ses.py
37% → 62%
sns.py
53% → 83%
stomp.py
20% → 81%
twilio.py
83% → 100%
zabbix.py
54% → 57%

Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for continuing to raise the unit test coverage!

@jertel jertel merged commit f49c4e3 into jertel:master Jun 25, 2021
@nsano-rururu nsano-rururu deleted the testcode5 branch June 25, 2021 20:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants