System notification improvements #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new config option:
notify_all_errors, that when set to True (default is False) will send notifications in the event of any error. Previously, only rule-specific or alert-specific errors would allow notifications to be sent. With this change, background task errors, or even loss of connectivity to the backend data store can now be configured to have notifications sent.Adds support to allow any of the included alerters to be used for delivering system error notifications. Previously, only unauthenticated emails could be sent. With this change, system errors can be delivered via Slack, PagerDuty, SMTPS, etc.
Deprecates the existing
notify_emailconfig option.Checklist
make test-dockerwith my changes.Questions or Comments