#110: Replace yaml loader with one that supports env value substitutions. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first change in python language, so advise if anything seems off. |
jertel
requested changes
May 11, 2021
| @@ -26,7 +26,6 @@ | |||
| from jira.exceptions import JIRAError | |||
| from requests.auth import HTTPProxyAuth | |||
| from requests.exceptions import RequestException | |||
| from staticconf.loader import yaml_loader | |||
There was a problem hiding this comment.
With these staticconf imports eliminated, is there any reason to retain the PyStaticConfiguration>=0.10.3 lines in requirements.txt and setup.py? If it's no longer needed let's get rid of that dep.
There was a problem hiding this comment.
I think we can remove.
There was a problem hiding this comment.
@nsano-rururu Do you concur? You've spent a lot of time reviewing those dependencies so your opinion is appreciated.
There was a problem hiding this comment.
@jertel Yes. is consent.
jertel
approved these changes
May 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.