Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document update, test code addition, etc. #132

Merged
merged 3 commits into from
May 7, 2021

Conversation

nsano-rururu
Copy link
Collaborator

requirements.txt and setup.py

  • remove configparser

requirements-dev.txt

  • tox 3.23.0 to 3.23.1

elastalert.rst

  • Corrected the corresponding alert notification names in alphabetical order

ruletypes.rst

  • Corrected the corresponding alert notification names in alphabetical order
  • Fixed a mistake in the description of slack_ca_certs

alerts_test.py

  • add

    • test_opsgenie_tags
    • test_opsgenie_message
    • test_opsgenie_alias
    • test_opsgenie_subject
    • test_opsgenie_subject_args
    • test_opsgenie_priority_p1
    • test_opsgenie_priority_p2
    • test_opsgenie_priority_p3
    • test_opsgenie_priority_p4
    • test_opsgenie_priority_p5
    • test_opsgenie_priority_none
    • test_opsgenie_proxy
    • test_ms_teams_proxy
    • test_slack_proxy
    • test_slack_username_override
    • test_slack_title_link
    • test_slack_title
    • test_slack_icon_url_override
    • test_slack_msg_color
    • test_slack_parse_override
    • test_slack_text_string
    • test_slack_alert_fields
    • test_slack_ca_certs
    • test_http_alerter_proxy
    • test_http_alerter_timeout
    • test_http_alerter_headers
    • test_http_alerter_post_ca_certs_true
    • test_http_alerter_post_ca_certs_false
    • test_pagerduty_alerter_v2_payload_class_args
    • test_pagerduty_alerter_v2_payload_component_args
    • test_pagerduty_alerter_v2_payload_group_args
    • test_pagerduty_alerter_v2_payload_source_args
    • test_pagerduty_alerter_v2_payload_custom_details
    • test_pagerduty_alerter_v2_payload_include_all_info
    • test_pagerduty_alerter_proxy
    • test_alerta_use_qk_as_resource
    • test_alerta_timeout
    • test_alerta_type
    • test_alerta_resource
    • test_alerta_service
    • test_alerta_environment
    • test_alerta_tags
    • test_alert_error
    • test_alert_get_aggregation_summary_text__maximum_width
    • test_pagertree_proxy
    • test_gitter_proxy
    • test_chatwork_proxy
    • test_telegram_proxy
    • test_telegram_text_maxlength
    • test_service_now_proxy
    • test_victor_ops_proxy
    • test_discord_proxy
    • test_discord_description_maxlength
    • test_dingtalk_proxy
    • test_mattermost_proxy
  • modify

    • test_command
    • test_resolving_rule_references
    • test_alerta_no_auth
    • test_alerta_auth
    • test_alerta_new_style
    • test_alert_subject_size_limit_no_args
    • test_mattermost_alert_text_only
    • test_mattermost_not_alert_text_only
    • test_mattermost_msg_fields
    • test_mattermost_icon_url_override
    • test_mattermost_channel_override
    • test_mattermost_ignore_ssl_errors

util_test.py

  • add
    • test_ts_to_dt_with_format
    • test_dt_to_ts_with_format
    • test_flatten_dict
    • test_pytzfy

requirements-dev.txt
  - tox 3.23.0 to 3.23.1

elastalert.rst
  - Corrected the corresponding alert notification names in alphabetical order

ruletypes.rst
  - Corrected the corresponding alert notification names in alphabetical order
  - Fixed a mistake in the description of slack_ca_certs

alerts_test.py
  add
    - test_opsgenie_tags
    - test_opsgenie_message
    - test_opsgenie_alias
    - test_opsgenie_subject
    - test_opsgenie_subject_args
    - test_opsgenie_priority_p1
    - test_opsgenie_priority_p2
    - test_opsgenie_priority_p3
    - test_opsgenie_priority_p4
    - test_opsgenie_priority_p5
    - test_opsgenie_priority_none
    - test_opsgenie_proxy
    - test_ms_teams_proxy
    - test_slack_proxy
    - test_slack_username_override
    - test_slack_title_link
    - test_slack_title
    - test_slack_icon_url_override
    - test_slack_msg_color
    - test_slack_parse_override
    - test_slack_text_string
    - test_slack_alert_fields
    - test_slack_ca_certs
    - test_http_alerter_proxy
    - test_http_alerter_timeout
    - test_http_alerter_headers
    - test_http_alerter_post_ca_certs_true
    - test_http_alerter_post_ca_certs_false
    - test_pagerduty_alerter_v2_payload_class_args
    - test_pagerduty_alerter_v2_payload_component_args
    - test_pagerduty_alerter_v2_payload_group_args
    - test_pagerduty_alerter_v2_payload_source_args
    - test_pagerduty_alerter_v2_payload_custom_details
    - test_pagerduty_alerter_v2_payload_include_all_info
    - test_pagerduty_alerter_proxy
    - test_alerta_use_qk_as_resource
    - test_alerta_timeout
    - test_alerta_type
    - test_alerta_resource
    - test_alerta_service
    - test_alerta_environment
    - test_alerta_tags
    - test_alert_error
    - test_alert_get_aggregation_summary_text__maximum_width
    - test_pagertree_proxy
    - test_gitter_proxy
    - test_chatwork_proxy
    - test_telegram_proxy
    - test_telegram_text_maxlength
    - test_service_now_proxy
    - test_victor_ops_proxy
    - test_discord_proxy
    - test_discord_description_maxlength
    - test_dingtalk_proxy
    - test_mattermost_proxy

  modify
    - test_command
    - test_resolving_rule_references
    - test_alerta_no_auth
    - test_alerta_auth
    - test_alerta_new_style
    - test_alert_subject_size_limit_no_args
    - test_mattermost_alert_text_only
    - test_mattermost_not_alert_text_only
    - test_mattermost_msg_fields
    - test_mattermost_icon_url_override
    - test_mattermost_channel_override
    - test_mattermost_ignore_ssl_errors

util_test.py
  add
    - test_ts_to_dt_with_format
    - test_dt_to_ts_with_format
    - test_flatten_dict
    - test_pytzfy
@nsano-rururu nsano-rururu requested a review from jertel May 7, 2021 10:40
Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional test coverage and doc updates!

@jertel jertel merged commit c2eeebe into jertel:master May 7, 2021
@nsano-rururu nsano-rururu deleted the add_testcode2 branch May 7, 2021 11:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants