Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lark alerter support #1282

Merged
merged 5 commits into from
Oct 8, 2023
Merged

Lark alerter support #1282

merged 5 commits into from
Oct 8, 2023

Conversation

seanyinx
Copy link
Contributor

Description

  • Added Lark alerter

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@nsano-rururu
Copy link
Collaborator

Please add documentation about Lark alerter
https://github.com/jertel/elastalert2/blob/master/docs/source/ruletypes.rst

@nsano-rururu
Copy link
Collaborator

nsano-rururu commented Sep 28, 2023

Changes were made to python:3.11-slim in another pull request, so no changes are required in this pull request.

@nsano-rururu
Copy link
Collaborator

It seems that the description in schema.yaml is incorrect.
Please modify as below.

  ### Lark
  lark_bot_id: {type: string}
  lark_msgtype: {type: string, enum: ['text']}

@jertel
Copy link
Owner

jertel commented Sep 29, 2023

@seanyinx Do you think you'll have time to update the docs and make those minor changes @nsano-rururu suggested in the next few days? If so I'll be able to include this in the next release. It's not urgent so if you need more time we can leave this for the next in about 2 months. Thanks!

@seanyinx
Copy link
Contributor Author

seanyinx commented Oct 7, 2023

@seanyinx Do you think you'll have time to update the docs and make those minor changes @nsano-rururu suggested in the next few days? If so I'll be able to include this in the next release. It's not urgent so if you need more time we can leave this for the next in about 2 months. Thanks!

Sorry, I was on vacation last week. It's not urgent and I will make the changes as suggested today.

@seanyinx
Copy link
Contributor Author

seanyinx commented Oct 7, 2023

It seems that the description in schema.yaml is incorrect. Please modify as below.

  ### Lark
  lark_bot_id: {type: string}
  lark_msgtype: {type: string, enum: ['text']}

@nsano-rururu @jertel Docs on Lark alerter added and suggested changes made. Thanks.

@jertel jertel merged commit 19880de into jertel:master Oct 8, 2023
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants