Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for custom deployment annotations #1271

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

victorpugin
Copy link
Contributor

@victorpugin victorpugin commented Sep 20, 2023

Description

Hello, we are willing to use elastalert2 at my company with https://github.com/stakater/Reloader to manage our rules in a custom configmap, but the chart doesn't allow to add deployment annotations. I propose to add that option.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@victorpugin victorpugin marked this pull request as ready for review September 20, 2023 10:22
@jertel
Copy link
Owner

jertel commented Sep 20, 2023

Hello, thanks for the contribution. Please confirm that the chart deploys with, and without custom deployment annotations, without any errors, and then check the "I have manually tested all relevant modes of the change in this PR".

@victorpugin
Copy link
Contributor Author

Hello, thanks for the contribution. Please confirm that the chart deploys with, and without custom deployment annotations, without any errors, and then check the "I have manually tested all relevant modes of the change in this PR".

Hello @jertel, I manually tested the chart with and without the custom deployment annotation successfully in production, it's working well.

@jertel jertel merged commit 76d6d32 into jertel:master Sep 20, 2023
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants