Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
jinja_root_name
support to the HTTP POST2 alerter--data
argument for rule testing to accept both a file with a single JSON document or a file with a proper JSON list of objectsExample file with single JSON object
Example file with list of JSON objects:
Checklist
make test-docker
with my changes.Questions or Comments
The change to
--data
for rule testing was added just for convenience. I was doing some testing and didn't realize the document needed to be a list of JSON objects. I didn't see anything stating it needed to be a list so I changed the code to allow for a single JSON object in the file or a list of JSON objects. The intent of this PR was not to make this change so if it's not wanted I'm okay with removing it