feat: add verify toggle for Kibana Shorten URL API #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jertel
reviewed
Nov 17, 2022
docs/source/ruletypes.rst
Outdated
| @@ -66,6 +66,8 @@ Rule Configuration Cheat Sheet | |||
| +--------------------------------------------------------------+ | | |||
| | ``kibana_password`` (string, no default) | | | |||
| +--------------------------------------------------------------+ | | |||
| | ``kibana_verify`` (boolean, default True) | | | |||
There was a problem hiding this comment.
Thanks for the submission!
Any thoughts on adding a _certs suffix, to be consistent with the existing verify_certs config setting?
There was a problem hiding this comment.
I don't mind making that change, wasn't sure how to name it initially
jertel
approved these changes
Nov 17, 2022
|
Thanks for merging this! When do you think a new version will be released? |
|
Releases are normally every 1-2 months. The last release was 4 weeks ago, so the next will probably be within 2 weeks. |
|
Hello, 2.9.0 was released this morning. |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
make test-dockerwith my changes.Questions or Comments
Unsure how to test it via tests (or if this needs to be tested with unit tests), let me know :)