Fix for issue #670 #673
Merged
Fix for issue #670 #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems not to be necessary to wait for the stream, so it could be shown directly. Also added some missing semicolons.
|
@ongeo-dev can you provide a simple AR.js app that uses this version, in order to test it easily? Just run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems not to be necessary to wait for the stream, so it could be shown directly.
Also added some missing semicolons.
What kind of change does this PR introduce?
Fix for 3rd party integration (https://github.com/cordova-rtc/cordova-plugin-iosrtc)
Can it be referenced to an Issue? If so what is the issue # ?
#670
How can we test it?
Start AR.js in Browser or as a cordoja app in iOS aith activated cordova-plugin-iosrtc
Summary
The cordova-plugin-iosrtc is a native replacement of the webrtc function. In iOS its only allowed to use in native safari browser but not in 3rd party apps using WkWebView.
The Plugin does not provide the videoElement.videoWith, that is used to check if the video stream is ready, but in my tests it has not been necessary to wait for it.
Does this PR introduce a breaking change?
I hope not.
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Tested on Cordova in iOS13.2.2 (iPhone 7) and Android 9 (Galaxy S9 - Patch 11/19)