Added ability to return the AR Controller Instance #666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the AR Controller Instance allows prototype commands to be called from outside of the aframe-ar.js class
What kind of change does this PR introduce?
New Feature
Can it be referenced to an Issue? If so what is the issue # ?
Getting Marker Locations - #636
How can we test it?
Used to get the quantity and position of the markers using:
var ARController = getARController();
var numMarkers = ARController.getMarkerNum();
var i;
for(i = 0 ; i< arController.getMarkerNum() ; i++){
console.log(arController.getMarker(i).pos);
}
Summary
Exposed Object so methods can be called from client - means we can get marker information out of Aframe and into our own program i.e the position thats being used to place the 3D overlay to changing the marker tracking type (colpour, mono) and more.
Does this PR introduce a breaking change?
Not that im aware of - perhaps saftey issyes?
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Firefox 70.0.1 + laptop i5 7200U + windows 10 home
Other information