You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@skunheal could you make a PR for this change? I see in your repo you are looping through the $request->query() to turn the param array into a string. Is there an easier way to get the query parameters as a string on the URL already? Seems like there should be something standard already there for that.
merijndk
added a commit
to merijndk/Laravel-Prerender
that referenced
this issue
Aug 23, 2019
Replaced the for loop with $request->getQueryString(). The only thing is that all URLs are now being sent with an "?" at the end even when there are no query parameters. Shouldn't be a problem tho.
Currently custom URLs are not passed to prerender.io.
www.yoursite.nl?param=0 will send a request without the param=0 to the prerender.io server:
return $this->client->get($this->prerenderUri . '/' . urlencode($protocol.'://'.$host.'/'.$path), compact('headers'));
Should become:
return $this->client->get($this->prerenderUri . '/' . urlencode($protocol.'://'.$host.'/'.$path.$paramsString), compact('headers'));
The text was updated successfully, but these errors were encountered: