test on 3.6 on Windows

jeroen · Oct 6, 2024 · 44a1e4e · 44a1e4e
1 parent 32be402
commit 44a1e4e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml
@@ -16,20 +16,12 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - {os: macOS-13,   r: 'release'}
-          - {os: macOS-14,   r: 'release'}
-          - {os: macOS-latest,   r: 'release', disable-static: 'disable-static'}
+          - {os: windows-latest, r: '3.6'}
           - {os: windows-latest, r: '4.0'}
           - {os: windows-latest, r: '4.1'}
           - {os: windows-latest, r: '4.2'}
           - {os: windows-latest, r: '4.3'}
           - {os: windows-latest, r: '4.4'}
-          - {os: windows-2022,   r: 'devel'}
-          - {os: ubuntu-latest,  r: 'devel', http-user-agent: 'release'}
-          - {os: ubuntu-latest,  r: 'release'}
-          - {os: ubuntu-24.04,   r: 'release', disable-static: 'disable-static'}
-          - {os: ubuntu-22.04,   r: 'release', disable-static: 'disable-static'}
-          - {os: ubuntu-20.04,   r: 'release', disable-static: 'disable-static'}
 
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

diff --git a/src/Makevars.win b/src/Makevars.win
@@ -5,9 +5,12 @@ RWINLIB = ../windows/libv8
 ifeq ($(R_COMPILED_BY),gcc 8.3.0)
 RWINLIB = ../windows/libv8$(R_ARCH)
 endif
+ifeq ($(R_COMPILED_BY),gcc 4.9.3)
+LEGACYFLAGS = -DISNODEJS=6.2
+endif
 
 # Enables pointer compression except for on 32-bit (legacy)
-PKG_CPPFLAGS = -I$(RWINLIB)/include -DV8_COMPRESS_POINTERS$(subst 64,,$(WIN))
+PKG_CPPFLAGS = -I$(RWINLIB)/include -DV8_COMPRESS_POINTERS$(subst 64,,$(WIN)) $(LEGACYFLAGS)
 PKG_LIBS = \
 	-L$(RWINLIB)/lib \
 	-lv8_monolith \