Add doNotRecurseIntoDirectory option?

[KyleAMathews]

It'd save some time on very big subdirectory trees if you could avoid reading subdirectories that you're going to ignore anyways e.g. node_modules. Better to just avoid reading those directories at all.

Would you be ok with a PR adding this?

[KyleAMathews]

Or perhaps just ignoreDirectory.

[KyleAMathews]

Ok this makes a big difference (for my use case anyways). On a Lerna monorepo with a number of packages and node_modules directories w/o ignoring node_modules, it took ~9 seconds to list files. When ignoring node_modules directories, it took 0.16 seconds.

I'll make a PR real quick!

[KyleAMathews]

Hmmm... though needing to add another argument complicates things. Would you be ok if we turn the first argument into an object with named arguments?

[jergason]

I like this idea. Reading every file and then just filtering them out does seem pretty inefficient.

[KyleAMathews]

Sweet! How do you want to handle adding the new argument?

[jergason]

I don't really care how we approach it, as long as we do it in a backwards-compatible way. I'd love to release this without bumping the major version number.

…

On Sat, Feb 4, 2017 at 6:27 PM, Kyle Mathews ***@***.***> wrote: Sweet! How do you want to handle adding the new argument? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#48 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEZWyAyA3Ea7cVbbYnRp4o35uO5d_fFks5rZSVugaJpZM4L1kHS> .

[Ajedi32]

FYI, pretty sure ignoring a directory already stops this module from recursing into it. See:

https://github.com/jergason/recursive-readdir/blob/v2.1.0/index.js#L47-L53

[MatthieuLemoine]

@jergason Are you still interested in this idea ?