Upgrade to ktlint 0.29.0 and fix warnings on incremental build properties #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymailen
changed the title
jeremymailen
commented
Oct 4, 2018
| @@ -13,6 +14,7 @@ import java.io.File | |||
|
|
|||
| open class FormatTask : SourceTask() { | |||
|
|
|||
| @Internal | |||
There was a problem hiding this comment.
We do this to prevent incremental build, which doesn't work quite right if you revert after since this task modifies input files. Gradle warns without it annotated.
jeremymailen
commented
Oct 4, 2018
| @@ -26,6 +27,10 @@ open class LintTask : SourceTask() { | |||
| @PathSensitive(PathSensitivity.RELATIVE) | |||
| lateinit var reports: Map<String, File> | |||
|
|
|||
| @InputFiles | |||
| @PathSensitive(PathSensitivity.RELATIVE) | |||
| override fun getSource() = super.getSource() | |||
There was a problem hiding this comment.
The desirable path sensitivity does not get inherited from SourceTask so it looks like we need to override just to annotate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.