Bump Ktlint to 0.47.1 (+ bump Kotlin to 1.7.10)
#275
Conversation
| @@ -11,7 +11,7 @@ internal fun editorConfigOverride(ktLintParams: KtLintParams): EditorConfigOverr | |||
| return if (rules.isEmpty()) { | |||
| EditorConfigOverride.emptyEditorConfigOverride | |||
| } else { | |||
| EditorConfigOverride.from(DefaultEditorConfigProperties.disabledRulesProperty to rules.joinToString(separator = ",")) | |||
| EditorConfigOverride.from(DefaultEditorConfigProperties.ktlintDisabledRulesProperty to rules.joinToString(separator = ",")) | |||
| .sortedWith( | ||
| compareBy { | ||
| when (it.id) { | ||
| "standard" -> 0 | ||
| else -> 1 | ||
| } | ||
| }, | ||
| ) |
There was a problem hiding this comment.
I didn't understand why sorting was required, but I preserved the behavior, despite the new returned type is a Set
There was a problem hiding this comment.
At one point way back we intentionally put standard rules first in the list although I can't dig up the reason why. It might have been to report them first, but this might be an obsolete concern.
| @@ -2,7 +2,7 @@ import org.jetbrains.kotlin.gradle.plugin.getKotlinPluginVersion | |||
| import org.jetbrains.kotlin.gradle.tasks.KotlinCompile | |||
|
|
|||
| plugins { | |||
| kotlin("jvm") version "1.7.0" | |||
| kotlin("jvm") version "1.7.10" | |||
There was a problem hiding this comment.
Out of curiosity, do we still work with 1.7.0 or do we need to update the compatibility matrix?
There was a problem hiding this comment.
I verified we're still compatible with kotlin 1.7.0 ✅
build.gradle.kts
Outdated
| @@ -27,7 +27,7 @@ description = projectDescription | |||
| object Versions { | |||
| const val androidTools = "7.2.1" | |||
| const val junit = "4.13.2" | |||
| const val ktlint = "0.46.1" | |||
| const val ktlint = "0.47.0" | |||
There was a problem hiding this comment.
Let's go to 0.47.1!
I've gotten into the habit of waiting a few days after each ktlint release because there's always a flurry of error reports and fast fixes. Seems like some important ones to pick up.
| .sortedWith( | ||
| compareBy { | ||
| when (it.id) { | ||
| "standard" -> 0 | ||
| else -> 1 | ||
| } | ||
| }, | ||
| ) |
There was a problem hiding this comment.
At one point way back we intentionally put standard rules first in the list although I can't dig up the reason why. It might have been to report them first, but this might be an obsolete concern.
mateuszkwiecinski
changed the title
0.47.0 (+ bump Kotlin to 1.7.10)0.47.10 (+ bump Kotlin to 1.7.10)
mateuszkwiecinski
changed the title
0.47.10 (+ bump Kotlin to 1.7.10)0.47.1 (+ bump Kotlin to 1.7.10)
The latest version of Ktlint deprecates some of the classes the plugin uses, so I migrated the code to the new apis.
This means Kotlinter will require Ktlint
0.47.0and up 👀