Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ktlint 0.35.0 (#117) #118

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Upgrade to ktlint 0.35.0 (#117) #118

merged 2 commits into from
Oct 17, 2019

Conversation

olegivo
Copy link
Contributor

@olegivo olegivo commented Oct 14, 2019

No description provided.

jeremymailen
jeremymailen reviewed Oct 16, 2019
View reviewed changes
Copy link
Owner

@jeremymailen jeremymailen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Tested it out on JVM and Android and looks like the upgrade is trouble free.

Please also update the version of kotlin to 1.3.50 to match what ktlint is at now. After that I'll get a new release out.

@olegivo
Copy link
Contributor Author

olegivo commented Oct 16, 2019

Ok

@olegivo
Copy link
Contributor Author

olegivo commented Oct 16, 2019

@jeremymailen , done

@jeremymailen jeremymailen merged commit 7f0920a into jeremymailen:master Oct 17, 2019
@jeremymailen
Copy link
Owner

Once again, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymailen jeremymailen jeremymailen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olegivo @jeremymailen