Lint task sometimes does not re-run when editorconfig changes

[jeremymailen]

Although we are supposed to consider the editorconfig file contents a build input and re-run lint tasks when it changes, somehow this isn't happening sometimes. It often leads users to perceive that one of their editorconfig settings is not working.
Reference #324 and #321

[christophsturm]

This problem happens to me all of the time. I don't know where the editorconfig file is cached but git clean -fxd fixes it for me.

[stopal]

I stumbled across this problem too upgrading to kotlinter-gradle 3.15.0 -> Ktlint 0.49.1.

This problem happens to me all of the time. I don't know where the editorconfig file is cached but git clean -fxd fixes it for me.

Unfortunately this doesnt do the trick for me. Really strange.

[realdadfish]

I also accidentally stumbled upon this trying out different configurations (i.e. changing .editorconfig, running formatKotlin, checking results, reverting changes, and starting again from step 1), and the behaviour was pretty much reproducible, however I was unable to debug into the plugin's code via -Dorg.gradle.debug=true, as for some reason my breakpoints weren't hit.

Anyways, for me it helped stopping the Gradle daemon in between runs or start formatKotlin right away with -Dorg.gradle.daemon=false.

[bravik]

./gradlew --stop && ./gradlew :link:lintKotlin

[jeremymailen]

Yeah, this is clearly a bug, but I need to find time to track it down and fix it. PRs welcome if someone else sees the solution.

[mateuszkwiecinski]

I'm unable to create a PR, but I can link the root cause:

kotlinter-gradle/src/main/kotlin/org/jmailen/gradle/kotlinter/tasks/ConfigurableKtLintTask.kt

Lines 31 to 35 in 2023cbb

	protected fun getChangedEditorconfigFiles(inputChanges: InputChanges) = if (inputChanges.isIncremental) {
	inputChanges.getFileChanges(editorconfigFiles).map(FileChange::getFile)
	} else {
	emptyList()
	}

- the if should be dropped. The exact failing scenario (with a bit of explanation) can be found on kotlinlang slack

[jeremymailen]

Thanks @mateuszkwiecinski I can definitely make a PR when I get back home from the holidays.
You should still have permission to make PRs, merge, release etc since you're still a contributor but if you're running into trouble I can try to fix whatever's gone wrong.