Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring indent_size from .editorconfig broken #132

Closed
jeremymailen opened this issue Feb 18, 2020 · 0 comments · Fixed by #133
Closed

Configuring indent_size from .editorconfig broken #132

jeremymailen opened this issue Feb 18, 2020 · 0 comments · Fixed by #133

Comments

@jeremymailen
Copy link
Owner

No longer honors the value specified, although configuring it in the kotlinter extension still works.

This functionality appears to have broken between 2.0.0 and 2.1.0, so somewhere in #111 things went wrong. Needs investigation. Could have been the ktlint upgrade or changes to this plugin.
@mateuszkwiecinski mateuszkwiecinski mentioned this issue Feb 18, 2020
Merged
jeremymailen pushed a commit that referenced this issue Mar 2, 2020
@mateuszkwiecinski
Fix #132 by respecting indent_size from .editorconfig (#133)
edd9d98 
* Fix respecting indent_size set from editorconfig
Remove unused `continuationIndentSize`

* Restore `continuationIndentSize` support, add deprecation warnings

* Add tests confirming extension properties override editorconfig ones

* Add tests case for `indent_size` precedence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #132 by respecting indent_size from .editorconfig
1 participant
@jeremymailen