Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Pipenv - Pipfile.lock #5404

Merged
merged 4 commits into from
Feb 10, 2023
Merged

feat: support Pipenv - Pipfile.lock #5404

merged 4 commits into from
Feb 10, 2023

Conversation

jeremylong
Copy link
Owner

@jeremylong jeremylong commented Jan 31, 2023

Adds support for Pipfile.lock per #4995.

This currently uses the exact same enable/disable settings as the PipfileAnalyzer - and will supersede the PipfileAnalyzer if bother a Pipfile and Pipfile.lock exist.

Adds support for Pipefile.lock per #4995
@boring-cyborg boring-cyborg bot added core changes to core tests test cases labels Jan 31, 2023
@boring-cyborg boring-cyborg bot added ant changes to ant cli changes to the cli maven changes to the maven plugin utils changes to utils labels Feb 1, 2023
@jeremylong jeremylong added this to the 8.1.0 milestone Feb 1, 2023
@aikebah
Copy link
Collaborator

aikebah commented Feb 6, 2023

Looks like autocorrect messed up your PR message (pipefile / pipelock / bother)

Code looks good to me.

One remark: I think it would be good to add some remark in the javadoc of both analyzers that they operate in tandem on the same activation property (with the new analyzer taking over when a lock file is present), so that when revisiting them in the future it's hinted by the docs that if one changes the other is likely to need change as well.

@jeremylong jeremylong changed the title feat: support Pipenv - Pipefile.lock feat: support Pipenv - Pipfile.lock Feb 9, 2023
Copy link
Collaborator

@aikebah aikebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit 4730296 into main Feb 10, 2023
@jeremylong jeremylong deleted the pipfileLoock branch February 10, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ant changes to ant cli changes to the cli core changes to core maven changes to the maven plugin tests test cases utils changes to utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants