Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add double quote for "properties.security-severity" to fix processing of SARIF file in GitHub #5345

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

mrclrchtr
Copy link
Contributor

@mrclrchtr mrclrchtr commented Jan 18, 2023

Fixes Issue

I'm so sorry. I somehow forgot the quotation marks in my PR here #5227

I don't know how that could have happened. This causes the following exception in github processing:

Error: Code Scanning could not process the submitted SARIF file:
parsing restricted subset of SARIF data has failed: parse error: expected string near offset 2910 of '7.2'

This PR adds the quotation marks.

@boring-cyborg boring-cyborg bot added the core changes to core label Jan 18, 2023
Copy link
Collaborator

@aikebah aikebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having the PR in before I could start working on it

@aikebah
Copy link
Collaborator

aikebah commented Jan 18, 2023

To bad it got noticed by you after @jeremylong already had been working hard to get 8.0.1 out, it will have to go into the next patch release

@aikebah aikebah merged commit e0ff724 into jeremylong:main Jan 18, 2023
@mrclrchtr
Copy link
Contributor Author

I also had the stackoverflow problems, that's why I could only test 8.0.1.

Sorry for the inconvenience and thanks for merging. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core changes to core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants