0.0.7 alpha #15
Merged
0.0.7 alpha #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Password Validator update is a BC breaking change. See https://github.com/jeremykendall/password-validator/releases/tag/3.0.0 for details.
The former implementation felt far too magical, considering it was very confusing to not add storage to the Bootstrap, there was no default storage in the Bootstrap, yet default storage was indeed set, but a level or two below Bootstrap. This change makes it very clear what the default storage implementation is and where it's getting set.
PHP 7 tests keep segfaulting. Ironically, all the tests run, and *then*
it segfaults, exiting with 139. Seems to be b/c xdebug is not installed
for PHP 7, but I don't care enough about PHP 7 to try and fix this. Not
yet, anyhow.
Here's an example of a PHP 7 segfault:
```
PHP 7.0.0-dev (cli) (built: Mar 24 2015 11:08:38)
Copyright (c) 1997-2015 The PHP Group
Zend Engine v3.0.0-dev, Copyright (c) 1998-2015 Zend Technologies
with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2015, by Zend Technologies
... snip ...
PHPUnit 4.5.0 by Sebastian Bergmann and contributors.
Configuration read from /home/travis/build/jeremykendall/slim-auth/travis.xml
The Xdebug extension is not loaded. No code coverage will be generated.
...................
Time: 542 ms, Memory: 8.00Mb
OK (19 tests, 51 assertions)
Collecting CodeCoverage information...
Sending coverage output...
/home/travis/build.sh: line 41: 3460 Segmentation fault phpunit -c travis.xml
travis_time:end:3140e8da:start=1427306427954747720,finish=1427306428622564267,duration=667816547
[0K
[31;1mThe command "phpunit -c travis.xml" exited with 139.[0m
Done. Your build exited with 1.
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.travis.ymlBootstrapnow setsZend\Authentication\Storage\Sessionas default storageBC Breaking Changes
loginroute now throwsHttpUnauthorizedException. Fixes Throw http 401 rather than redirect to 'login' #11.3.*3.0.0