Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates of possible interest #81

Merged
merged 7 commits into from
Nov 5, 2020
Merged

Conversation

ConradHughes
Copy link
Collaborator

Hi Jeff,

Thanks very much for keeping cropgui going. I've a few updates here which might be of interest:

  • Use of 'cp' during install invokes umask which can leave unreadable files installed; use 'install' instead.
  • I've added a script to create four test images which help verifying correct behaviour under rotations and different JPEG block sizes.
  • Also added some extra keyboard controls for processing multiple images at a time: 's' to allow you to take multiple crops from one image, 'n' to skip to the next, and 'q' to quit. Hm. I should probably find somewhere to document these.
  • This involved a bugfix to the event handler, where pressing return while processing multiple images would skip on two images rather than just to the next.
  • Minor thing, but title/parent parameter order was a bit inconsistent in the file chooser stuff; fixed.

I have another patch which offers correct crop rounding, but am not sure whether it's worth pushing. The current always-round-to-block-size behaviour for all four edges is overly aggressive, in that the bottom and right edges of any crop don't need to be block-aligned, but unfortunately jpegtran itself doesn't handle this correctly for rotated images even if provided with a valid command line. I'm looking into trying to produce a patch for that..

Conrad Hughes added 7 commits November 2, 2020 16:26
'cp' subject to umask problems: use 'install'.
This time the fix is all here!
Also fix event handler bug.
Also slightly improved file chooser behaviour.
Controls:
  'n' for next image without saving
  'q' to quit
  's' to save a crop from this image without going to next
Also eliminate redundant get_cropspec code.
Also eliminate redundant apply_rotation call.
@jepler jepler merged commit fb5ff13 into jepler:master Nov 5, 2020
@ConradHughes ConradHughes deleted the cjch_updating branch November 5, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants