Copy file if no cropping or rotation is required. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through testing it was discovered that jpegtran still modifies files when no cropping or rotation is given (0 pixels, 0 degrees). Using imagemagick to compare resulting reconstructed images pixel by pixel it was determined that no pixel values are actually changed by jpegtran in this case, however these images always grow in file size (minimally).
This commit fixes this by simply copying the target file if no cropping or rotating is required. I wasn't sure of the best way to implement this, but I think it makes sense output a file whenever a user clicks 'crop,' even if no crop pixels or rotation are given. If a user doesn't want to output a file, they can select 'skip,' instead.