Skip to content

Commit

Permalink
Fix old-arch component not updating background in interop layer examp…
Browse files Browse the repository at this point in the history
…le (facebook#36924)

Summary:
I've noticed that in the Fabric Interop Layer sample on RN-Tester, when running with Old Arch, the legacy view is not receiving the commands correctly.
This is due to us not sending the command as string, which is making the command fail to deliver.

## Changelog:

[INTERNAL] - Fix old-arch component not updating background in interop layer example

Pull Request resolved: facebook#36924

Test Plan:
Tested locally:

| Before | After |
|--------|--------|
| ![screen-1681728104](https://user-images.githubusercontent.com/3001957/232461662-68b23545-f38c-40fe-9a5d-44bb0cae29e9.png) | ![screen-1681728077](https://user-images.githubusercontent.com/3001957/232461651-eec93a51-b0f0-4650-af3a-c5dd991f2f96.png) |

Reviewed By: cipolleschi

Differential Revision: D45043929

Pulled By: cortinico

fbshipit-source-id: 8bb2a052a1a600046f3a16c868062c5e600385f0
  • Loading branch information
cortinico authored and jeongshin committed May 7, 2023
1 parent 3b7fbb8 commit 1271b06
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ export function callNativeMethodToChangeBackgroundColor(
}
UIManager.dispatchViewManagerCommand(
ReactNative.findNodeHandle(viewRef),
UIManager.getViewManagerConfig('RNTMyLegacyNativeView').Commands
.changeBackgroundColor,
UIManager.getViewManagerConfig(
'RNTMyLegacyNativeView',
).Commands.changeBackgroundColor.toString(),
[color],
);
}
Expand Down

0 comments on commit 1271b06

Please sign in to comment.