Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: drop support for Python 3.9, add support for Python 3.11 #445

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

jenstroeger
Copy link
Owner

No description provided.

behnazh
behnazh previously approved these changes Jan 16, 2023
@behnazh behnazh dismissed their stale review January 16, 2023 08:55

Need more discussions.

@jenstroeger
Copy link
Owner Author

@behnazh I’m unsure about the breaking change chore!: here 🤔 What do you think?

@behnazh
Copy link
Collaborator

behnazh commented Jan 19, 2023

@behnazh I’m unsure about the breaking change chore!: here thinking What do you think?

It's a tricky one because this may or may not be a breaking change depending on the downstream repositories. I would slightly prefer to make it a breaking change to communicate the potential side effects?

@jenstroeger
Copy link
Owner Author

It's a tricky one because this may or may not be a breaking change depending on the downstream repositories. I would slightly prefer to make it a breaking change to communicate the potential side effects?

Ok then let’s keep the PR title as-is 👍🏼

@jenstroeger jenstroeger merged commit 144aac7 into staging Jan 20, 2023
@jenstroeger jenstroeger deleted the drop-py39-add-py311 branch January 22, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants